Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unresponsive chart containers #324

Merged
merged 10 commits into from
Jan 27, 2021
Merged

fix unresponsive chart containers #324

merged 10 commits into from
Jan 27, 2021

Conversation

macfarlandian
Copy link
Collaborator

Description of the change

Fixes a silly layout issue that I had not thought to address the first time around but is hampering development now that there are actual charts on the pages: the narrative pages now grow and shrink in width as the window is resized, and the text and chart columns stay in roughly the same proportions. The text has a maximum width, so on very large screens the charts will keep growing while the text does not. Screen real estate is more valuable for the charts at that point.

(This still doesn't implement a mobile layout but it should now look reasonable on medium-to-large screens.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #317

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jan 26, 2021

Pull Request Test Coverage Report for Build 513898374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.31%

Totals Coverage Status
Change from base Build 513889722: 0.0%
Covered Lines: 1705
Relevant Lines: 2513

💛 - Coveralls

Base automatically changed from ian/278-filters to master January 27, 2021 02:25
@macfarlandian macfarlandian merged commit f266832 into master Jan 27, 2021
@macfarlandian macfarlandian deleted the ian/317-layout branch January 27, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nonresponsive layout
3 participants