-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorical breakdown sections #332
Conversation
This reverts commit 8af4e1d.
Pull Request Test Coverage Report for Build 528977391
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bubbles look really great! There's a slight delay between the labels and bubbles when you resize the window, but I'm assuming that is somewhat expected?
// because the bottom edge of each circle is aligned with the bottom, | ||
// and the hypotenuse is a line connecting the centers, we know that | ||
// c is the sum of the radii and b is the difference between them. | ||
// Then we just solve for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very interesting, thanks for the explanation
) { | ||
super(props); | ||
|
||
makeObservable(this, { dataSeries: computed }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pretty nice that the data can just be a computed value...I'm thinking we probably wouldn't be able to do something similar in pulse-dashboard because of the authentication..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean as long as the authentication data is also observable, there ought to be a way ...
yeah that label issue is just a Semiotic thing, I wasn't able to figure out a way to change it the first time around (and ... I did not try this time) |
Description of the change
Another visualization type ported over from v1. This is used in the prison releases, prison admissions, and supervision revocations sections.
This PR looks large but a pretty big chunk of it is whitespace changes and code copied wholesale from v1 so hopefully it is not too arduous to review. (I didn't break out the chart component as a separate PR because last time I did that, I found that not being able to actually, you know, see the chart meant I wound up having to change a bunch of stuff once I plugged it into the page.)
Highlights:
Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: