Prison stay lengths section with bar charts

[macfarlandian]

Description of the change

Ports over another chart component, the BarChartTrellis, to implement the prison stay lengths section. This was really only a UI change since this section uses the same data handling logic implemented in #332 .

The BarChartTrellis component is simplified compared to its v1 counterpart, because the layout is different (single column) and it doesn't really need the Semiotic FacetController (the v1 component probably didn't really need that controller either, we live and learn). This in turn let me remove some special case handling from the ResponsiveTooltipController (specifically the render prop, which was only needed to support FacetController). Some assorted type changes and cleanup fell out of that.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #303, closes #304

Checklists

Development

These boxes should be checked by the submitter prior to merging:

• Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

• This pull request has a descriptive title and information useful to a reviewer
• This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
• Potential security implications or infrastructural changes have been considered, if relevant

[coveralls]

Pull Request Test Coverage Report for Build 535119573

• 47 of 54 (87.04%) changed or added relevant lines in 11 files are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.3%) to 67.753%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
spotlight-client/src/charts/utils.ts	5	6	83.33%
spotlight-client/src/VizPrisonStayLengths/VizPrisonStayLengths.tsx	14	17	82.35%
spotlight-client/src/charts/ResponsiveTooltipController.tsx	4	7	57.14%

Files with Coverage Reduction	New Missed Lines	%
spotlight-client/src/charts/ResponsiveTooltipController.tsx	3	46.15%

Totals
Change from base Build 534607744:	0.3%
Covered Lines:	1911
Relevant Lines:	2728

---

💛 - Coveralls

[macfarlandian]

realized after opening the PR that I had broken highlighting with my type changes ... fixed it and added a hook to consolidate some type checking for highlight states to try and harmonize things a bit more

[jovergaag]

📽️

I meant to approve Daniela's PR - un approving since I haven't finished looking at this yet :)

[macfarlandian]

🎢

[daschi]

🏖️

[daschi]

I was wondering if this would also be the place to test that we see the NoMetricData component when metric has an error?

[macfarlandian]

hmm yeah I haven't been doing that due in part to laziness (error handling is tested in the Metric model but not in the UI) but also because the error handling is still kind of a placeholder ... there is a ticket #327 to flesh it out, I made a note there about the existing test coverage because it may depend on what the real designs are