Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSONified errors and a -panic option. #48

Merged
merged 5 commits into from
Jun 26, 2017
Merged

Add JSONified errors and a -panic option. #48

merged 5 commits into from
Jun 26, 2017

Conversation

patrickt
Copy link
Contributor

@patrickt patrickt commented Jun 24, 2017

Up until now, error handling has been done through panic(), which isn't so great, as it just dumps the error text and a bunch of goroutine-related detritus to stderr. This patch adds an error field to the toplevel returned object; if it's present, an error has been encountered.

There is a huge wart here—the error type returned from parser syntax errors is opaque, so we can't extract its position information. We'll just have to parse the information on the Haskell side. Blech.

@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #48 into master will decrease coverage by 1.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   60.57%   59.14%   -1.43%     
==========================================
  Files           1        1              
  Lines         662      678      +16     
==========================================
  Hits          401      401              
- Misses        229      245      +16     
  Partials       32       32
Impacted Files Coverage Δ
goblin.go 59.14% <0%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac58ac9...5393bb5. Read the comment docs.

@vmchale vmchale self-requested a review June 26, 2017 16:31
@patrickt patrickt merged commit 03c3a59 into master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants