Add JSONified errors and a -panic option. #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, error handling has been done through
panic()
, which isn't so great, as it just dumps the error text and a bunch of goroutine-related detritus to stderr. This patch adds anerror
field to the toplevel returned object; if it's present, an error has been encountered.There is a huge wart here—the error type returned from parser syntax errors is opaque, so we can't extract its position information. We'll just have to parse the information on the Haskell side. Blech.