Catch setDisplayOrientation() RuntimeException #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpribble
force-pushed
the
catch_setDisplayOrientation_exception
branch
from
608bb75
to
e016142
Compare
Catch setDisplayOrientation() RuntimeException in UpdateOrientationRoutine and pass it to the CameraErrorCallback.
jpribble
force-pushed
the
catch_setDisplayOrientation_exception
branch
from
e016142
to
65c67ca
Compare
dmitry-zaitsev
requested changes
Oct 29, 2017
| try { | ||
| cameraDevice.setDisplayOrientation(degrees); | ||
| } catch (RuntimeException e) { | ||
| cameraErrorCallback.onError(new CameraException(e)); |
There was a problem hiding this comment.
There is a problem with that - at the moment onError basically means "everything is super bad, camera is dead". However, it is very likely not the case here, since orientation events are constantly coming in.
I would instead do it like it is done in Camera1#autoFocus where we just log the failure in logFailedAutoFocus.
There was a problem hiding this comment.
Ok. I'll make that change.
| verify(cameraDevice).setDisplayOrientation(90); | ||
| ArgumentCaptor<CameraException> argumentCaptor = ArgumentCaptor.forClass(CameraException.class); | ||
| verify(cameraErrorCallback).onError(argumentCaptor.capture()); |
There was a problem hiding this comment.
Small thing - ArgumentCaptor is not really needed here. You can just do:
verify(cameraErrorCallback).onError(exception);
0aff624
to
ba69cce
Compare
dmitry-zaitsev
approved these changes
Oct 30, 2017
|
Thanks for fixing the issue! This will into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch setDisplayOrientation() RuntimeException in UpdateOrientationRoutine.
This fixes issue #105.