Skip to content
This repository has been archived by the owner on Jul 11, 2021. It is now read-only.

Crash when command includes \x00 #50

Closed
siscia opened this issue Apr 28, 2019 · 1 comment
Closed

Crash when command includes \x00 #50

siscia opened this issue Apr 28, 2019 · 1 comment

Comments

@siscia
Copy link
Collaborator

siscia commented Apr 28, 2019

While working on pg-redis-proxy, it became clear that RediSQL crash if a command contains the null character.

To fix.
siscia added a commit that referenced this issue Apr 29, 2019
@siscia
Reproduce error reported on #50, NULL terminator in input cause error.
73a3b20 
Indeed we internally use CString::new that return NulError if the string contains NULL characters.
siscia added a commit that referenced this issue Apr 29, 2019
@siscia
#50, fix issue, remove trailing NULL chars if present
206780b
@siscia
Copy link
Collaborator Author

siscia commented Apr 29, 2019

Solved by #51

@siscia siscia closed this as completed Apr 29, 2019
siscia added a commit that referenced this issue May 8, 2019
@siscia
Reproduce error reported on #50, NULL terminator in input cause error.
197e498 
Indeed we internally use CString::new that return NulError if the string contains NULL characters.
siscia added a commit that referenced this issue May 8, 2019
@siscia
#50, fix issue, remove trailing NULL chars if present
4568c1f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siscia