fix: refactor graphback to hide unused features #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const { typeDefs, resolvers, contextCreator } = buildGraphbackAPI(modelDefs, { | ||
| crud: { | ||
| create: true, |
There was a problem hiding this comment.
Suggested change
| create: true, | |
| create: false, |
There was a problem hiding this comment.
I missed this feature. Nice to see it exposed like this 👍
There was a problem hiding this comment.
Yep. We can enable them on models directly or globally. I felt like in this case global one is needed.
Comment on lines
28
to
33
| crud: { | ||
| create: false, | ||
| update: true, | ||
| find: true, | ||
| findOne: true, | ||
| delete: true, | ||
| subCreate: false, | ||
| subUpdate: false, | ||
| subDelete: false | ||
| }, |
There was a problem hiding this comment.
The values default to true, so you can just pass the ones you want to change.
Suggested change
| crud: { | |
| create: false, | |
| update: true, | |
| find: true, | |
| findOne: true, | |
| delete: true, | |
| subCreate: false, | |
| subUpdate: false, | |
| subDelete: false | |
| }, | |
| crud: { | |
| create: false, | |
| subCreate: false, | |
| subUpdate: false, | |
| subDelete: false | |
| }, |
| version: '3' | ||
|
|
||
| services: | ||
| postgres: |
There was a problem hiding this comment.
There's a custom Postgres dockerfile we're using. You can copy this configuration.
There was a problem hiding this comment.
The reason for this is that it provides a pre-seeded DB for testing.
There was a problem hiding this comment.
I struggled to run it - credentials would not allow me to log in for some reason.
evanshortiss
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve server-side application and lock graphback versions to usable ones.
What was done
Use fixed versions of packages (they might break if updated outside the scope so we want to pin them. Renovate is configured to update them together same with github updates
Move graphback specific code out of the index for visibility
Disable graphback subscriptions as they might be confusing for the users (subscriptions will not deliver the changes in the database as one might expect (they will be only delivering changes that happening thru graphql API.
Why this was done
I wanted to avoid misunderstanding about subscriptions and streaming. Our team will do POC on top of this repository to connect junction stream to the subscriptions - this is for our own needs for the moment it is important to disable queries that might confuse potential developers trying the api.
Verification
I struggled to verify this changes because of the connection details for knex. Our templates use .env files. I have added temporary docker-compose file and tried to run it by
but could not. If you can try if that works for you that will be great.