Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor graphback to hide unused features #3

Merged
merged 3 commits into from
Sep 14, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions services/iot-graphql-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
},
"license": "Apache 2.0",
"dependencies": {
"@graphback/runtime-knex": "~0.16.1",
"@graphql-codegen/add": "~2.0.1",
"@graphql-codegen/typescript": "~1.17.9",
"@graphback/runtime-knex": "0.16.2",
"@graphql-codegen/add": "2.0.1",
"@graphql-codegen/typescript": "1.17.9",
"apollo-server-express": "~2.17.0",
"cors": "~2.8.5",
"dotenv": "~8.2.0",
Expand All @@ -27,20 +27,20 @@
"graphback": "~0.16.2",
"graphql": "~15.3.0",
"graphql-config": "~3.0.3",
"graphql-migrations": "~0.16.1",
"graphql-subscriptions": "~1.1.0",
"graphql-tag": "~2.11.0",
"knex": "~0.21.5",
"pg": "~8.3.3"
"graphql-migrations": "0.16.2",
"graphql-subscriptions": "1.1.0",
"graphql-tag": "2.11.0",
"knex": "0.21.5",
"pg": "8.3.3"
},
"devDependencies": {
"@graphql-cli/codegen": "~1.17.8",
"@graphql-cli/codegen": "1.17.8",
"@types/bson": "~4.0.2",
"@types/glob": "~7.1.3",
"@types/graphql": "~14.2.3",
"@types/graphql": "14.5.0",
"@types/node-fetch": "~2.5.7",
"graphback-cli": "~0.16.1",
"graphql-cli": "~4.0.0",
"graphback-cli": "0.16.2",
"graphql-cli": "4.1.0-beta.1",
"prettier": "~2.1.1",
"ts-node": "~9.0.0",
"tslint": "~6.1.3",
Expand Down
56 changes: 56 additions & 0 deletions services/iot-graphql-api/src/graphback.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import { createKnexDbProvider } from '@graphback/runtime-knex'
import { ApolloServer } from 'apollo-server-express'
import { buildGraphbackAPI } from 'graphback'
import { loadConfigSync } from 'graphql-config'
import { removeNonSafeOperationsFilter, migrateDB } from 'graphql-migrations'
import { connectDB, loadDBConfig } from './db'

/**
* create Apollo server using automatically generated resolvers
*/
export const createApolloServer = () => {
const graphbackExtension = 'graphback'
const config = loadConfigSync({
extensions: [
() => ({
name: graphbackExtension
})
]
})

const projectConfig = config.getDefault()
const graphbackConfig = projectConfig.extension(graphbackExtension)
const modelDefs = projectConfig.loadSchemaSync(graphbackConfig.model)

const db = connectDB()

const { typeDefs, resolvers, contextCreator } = buildGraphbackAPI(modelDefs, {
crud: {
create: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
create: true,
create: false,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this feature. Nice to see it exposed like this 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We can enable them on models directly or globally. I felt like in this case global one is needed.

update: true,
find: true,
findOne: true,
delete: true,
wtrocki marked this conversation as resolved.
Show resolved Hide resolved
subCreate: false,
subUpdate: false,
subDelete: false
},
dataProviderCreator: createKnexDbProvider(db)
})

const dbConfig = loadDBConfig()
migrateDB(dbConfig, typeDefs, {
operationFilter: removeNonSafeOperationsFilter
}).then(() => {
console.log('Migrated database')
})
wtrocki marked this conversation as resolved.
Show resolved Hide resolved

const apolloServer = new ApolloServer({
typeDefs,
resolvers: [resolvers],
context: contextCreator
})

return apolloServer;
}

44 changes: 4 additions & 40 deletions services/iot-graphql-api/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
import { ApolloServer } from 'apollo-server-express'
import cors from 'cors'
import express from 'express'
import http from 'http'
import { buildGraphbackAPI } from 'graphback'
import { loadDBConfig, connectDB } from './db'
import { migrateDB, removeNonSafeOperationsFilter } from 'graphql-migrations'
import { createKnexDbProvider } from '@graphback/runtime-knex'
import { loadConfigSync } from 'graphql-config'
import { HTTP_RESPONSE_DELAY, NODE_ENV, HTTP_PORT } from './config'
import { createApolloServer } from './graphback'

const app = express()

app.use(cors())

app.use((req, res, next) => {
app.use((req: Express.Request, res: Express.Response, next) => {
if (HTTP_RESPONSE_DELAY && NODE_ENV === 'dev') {
// Simulate request processing time in dev mode
setTimeout(() => next(), HTTP_RESPONSE_DELAY)
Expand All @@ -22,43 +17,12 @@ app.use((req, res, next) => {
}
})

const graphbackExtension = 'graphback'
const config = loadConfigSync({
extensions: [
() => ({
name: graphbackExtension
})
]
})

const projectConfig = config.getDefault()
const graphbackConfig = projectConfig.extension(graphbackExtension)
const modelDefs = projectConfig.loadSchemaSync(graphbackConfig.model)

const db = connectDB()
const dbConfig = loadDBConfig()

const { typeDefs, resolvers, contextCreator } = buildGraphbackAPI(modelDefs, {
dataProviderCreator: createKnexDbProvider(db)
})

migrateDB(dbConfig, typeDefs, {
operationFilter: removeNonSafeOperationsFilter
}).then(() => {
console.log('Migrated database')
})

const apolloServer = new ApolloServer({
typeDefs,
resolvers: [resolvers],
context: contextCreator
})

const apolloServer = createApolloServer();
apolloServer.applyMiddleware({ app })

const httpServer = http.createServer(app)
apolloServer.installSubscriptionHandlers(httpServer)

httpServer.listen({ port: HTTP_PORT }, () => {
console.log(`🚀 Server ready at http://localhost:${HTTP_PORT}/graphql`)
console.log(`🚀 Graphback Server ready at http://localhost:${HTTP_PORT}/graphql \nFor more information see: https://graphback.dev`)
})