This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Filter out any password from the manifest #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
approved these changes
Aug 13, 2019
|
maybe add a small spec to show that password fields are filtered. |
|
@abellotti specs don't seem to be passing in this repo |
|
@agrare @abellotti yeah, I disabled the Ruby checks in Travis because I never got them to work when I started this plugin.. I was going to ask for some help figuring that out: #2 |
agrare
force-pushed
the
filter_out_password_fields_from_manifest
branch
2 times, most recently
from
bef4fbd
to
61c151f
Compare
abellotti
reviewed
Aug 14, 2019
spec/manageiq
Outdated
| @@ -0,0 +1 @@ | |||
| /home/agrare/src/manageiq/manageiq | |||
There was a problem hiding this comment.
probably shouldn't be here.
There was a problem hiding this comment.
Ugh yeah, the .gitignore for this repo is all wrong
Mitigate issues where someone could upload a manifest with the intention of collecting passwords from the database by stripping out any of the "password" fields defined in Vmdb::SettingsWalker
agrare
force-pushed
the
filter_out_password_fields_from_manifest
branch
from
61c151f
to
0331fa1
Compare
|
Okay @abellotti if you change vmdb_plugin? to true this passes rspec locally |
|
Checked commits agrare/cfme-migration_analytics@0331fa1~...b8d59cd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
abellotti
approved these changes
Aug 14, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2019
…nifest Filter out any password from the manifest (cherry picked from commit 976dd3b)
|
Ivanchuk backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate issues where someone could upload a manifest with the intention
of collecting passwords from the database by stripping out any of the
"password" fields defined in Vmdb::SettingsWalker
Depends on ManageIQ/manageiq#19103