[RHCLOUD-20060] Add custom annotations to Deployment and jobs #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psav
requested changes
Jul 20, 2022
controllers/cloud.redhat.com/providers/metrics/subscriptions/Subscription.go
Show resolved
Hide resolved
|
Thanks! This should be good to go. Have a look and let me know! |
psav
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to define custom annotations for deployments and jobs. Kuttl tests are also added to validate that they work.
This patch is pretty simple, but one quirk to note was that rather than compose ObjectMeta into Deployment I added a new DeploymentMetadata type with an annotations map hanging off that. I made that decision because I figured we may not want Clowder users to be able to set full ObjectMeta on it. That may have been the wrong decision so let me know.