Cert auth #851
Merged
Cert auth #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psav
force-pushed
the
psav/cert_auth
branch
10 times, most recently
from
8368ec0
to
4cbda54
Compare
adamrdrew
previously approved these changes
Sep 13, 2023
There was a problem hiding this comment.
I think this is a good change set. The new code all makes sense to me. Going through it together helped which is why I have no questions, but it all makes sense. It follows what's idiomatic for clowder. The refactors here are good too. I don't really have anything to add except for the minor suggestions in the cache code and errors. LGTM!!!!
psav
force-pushed
the
psav/cert_auth
branch
from
4cbda54
to
bdeff37
Compare
|
/retest |
1 similar comment
|
/retest |
psav
force-pushed
the
psav/cert_auth
branch
from
6141a6a
to
79b206a
Compare
|
/retest |
1 similar comment
|
/retest |
psav
force-pushed
the
psav/cert_auth
branch
3 times, most recently
from
1cfe153
to
a2e6453
Compare
psav
force-pushed
the
psav/cert_auth
branch
from
a2e6453
to
761bb19
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do