[RHICOMPL-574] Fix issues with versions containing 0 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 74.46% 74.52% +0.05%
==========================================
Files 58 58
Lines 885 887 +2
Branches 121 122 +1
==========================================
+ Hits 659 661 +2
Misses 196 196
Partials 30 30
Continue to review full report at Codecov.
|
bastilian
commented
Sep 3, 2020
| expect(result).toEqual(true); | ||
| }); | ||
|
|
||
| it('return false for both versions being 0', () => { |
There was a problem hiding this comment.
This should in theory not happen with a backend that has proper data and imported hosts correctly and we should not have a OS version 0.0, but just to be sure.
|
LGTM |
akofink
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were issues with how the conditions got interpreted with
&&.With version numbers like
8.0it would show just0.This fixes these issues and OS information is correctly shown.