Add pendo and user information #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
reviewed
Oct 16, 2018
src/pug/header.pug
Outdated
| @@ -1,3 +1,7 @@ | |||
| script(src='/insights/static/chrome/js/chrome.js') | |||
| script. | |||
| window.getName(); | |||
There was a problem hiding this comment.
Can you call this function from chrome instead of HTML? I am kinda worried that the chrome file will get loaded twice.
src/js/chrome.js
Outdated
| import jwt from 'jwt-redhat'; | ||
|
|
||
| const onAuth = auth(); | ||
|
|
||
| onAuth.then(() => { | ||
| analytics(jwt.getUserInfo()); |
There was a problem hiding this comment.
Can you call the getName function from here? So the data will be loaded emediately when user logs in.
|
@karelhala I abstracted some of the stuff, so take another look and tell me what you think. Not sure if abstracting the |
karelhala
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.