Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome cache #512

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Fix chrome cache #512

merged 3 commits into from
Jan 31, 2020

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Dec 13, 2019 •
edited
Loading

Fix chrome cache:

  • Only one (latest) item of certain type is stored in the cache(e.g. main.yml).
  • Request are not send when item is in cache.
  • After timeout new request is send.
  • Cache is working even when switching between applications

https://projects.engineering.redhat.com/browse/RHCLOUD-3382

I have tested it a bit and it seems to work, but I would be glad if someone else would verify that is really working as it should

@PanSpagetka PanSpagetka changed the title Fix chrome cache [WIP] Fix chrome cache Dec 13, 2019
@PanSpagetka PanSpagetka force-pushed the fix-chrome-cache branch 2 times, most recently from 61e6fc2 to ca882e6 Compare January 30, 2020 12:29
@PanSpagetka PanSpagetka changed the title [WIP] Fix chrome cache Fix chrome cache Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020 •
edited
Loading

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   60.68%   60.68%           
=======================================
  Files          45       45           
  Lines         842      842           
  Branches      158      158           
=======================================
  Hits          511      511           
  Misses        271      271           
  Partials       60       60

karelhala
karelhala approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooo! Nice!

@karelhala karelhala merged commit bff83a3 into RedHatInsights:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@kruai kruai Awaiting requested review from kruai

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PanSpagetka @codecov-io @karelhala