Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added has permission navigation check. #663

Merged

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Mar 3, 2020

Changes

  • navigation items can be now hidden by user permission

cc @karelhala @gmcculloug

@codecov-io
Copy link

Codecov Report

Merging #663 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage    60.8%   60.65%   -0.15%     
==========================================
  Files          45       45              
  Lines         847      849       +2     
  Branches      162      163       +1     
==========================================
  Hits          515      515              
- Misses        271      272       +1     
- Partials       61       62       +1
Impacted Files Coverage Δ
src/js/consts.js 89.28% <0%> (-6.87%) ⬇️

@karelhala karelhala merged commit 71d8a64 into RedHatInsights:master Mar 3, 2020
@Hyperkid123 Hyperkid123 deleted the permission-based-navigation branch March 3, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants