Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct pendo config now #848

Merged
merged 2 commits into from
Jun 25, 2020
Merged

use the correct pendo config now #848

merged 2 commits into from
Jun 25, 2020

Conversation

ryelo
Copy link
Member

@ryelo ryelo commented Jun 24, 2020

We need to redo the entitlements to show both regular and trials as well as showing the normalized pathname (not containing beta)

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #848 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   61.12%   61.10%   -0.03%     
==========================================
  Files          46       46              
  Lines         885      887       +2     
  Branches      170      170              
==========================================
+ Hits          541      542       +1     
- Misses        280      282       +2     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
src/js/analytics.js 68.75% <33.33%> (-2.68%) ⬇️

@ryelo ryelo merged commit 00e98a7 into master Jun 25, 2020
@ryelo ryelo deleted the fixes/pendo-config branch June 25, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants