Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pendo-syncher deployment config #954

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Adding pendo-syncher deployment config #954

merged 5 commits into from
Jul 16, 2021

Conversation

tahmidefaz
Copy link
Member

Overview

This PR is being created to address this Jira.
PR to add the deployment config for the new pendo-syncher cronjob.

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@tahmidefaz
Copy link
Member Author

Plan is to run this every 2 hours to collect as much info as possible for debugging purposes before flipping the switch and enable PENDO_SYNC_ACTIVE. After which, we will run this once a day.

thearifismail
thearifismail reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@thearifismail thearifismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging should wait until tests in a cluster.

deployment.yaml Show resolved Hide resolved
@tahmidefaz
Copy link
Member Author

@thearifismail Can you give me direction on how to test this in a cluster?

@thearifismail
Copy link
Contributor

@tahmidefaz Will do after I verify that my ephemeral namespace is working as expected.

kruai
kruai reviewed Jul 16, 2021
View reviewed changes
deployment.yaml Outdated Show resolved Hide resolved
kruai
kruai previously approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thearifismail
thearifismail previously approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@thearifismail thearifismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tahmidefaz tahmidefaz dismissed stale reviews from thearifismail and kruai via be26707 July 16, 2021 13:42
@tahmidefaz
Copy link
Member Author

@kruai @thearifismail can you guys take a look again? I had to resolve the merge conflict

kruai
kruai previously approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tahmidefaz
Copy link
Member Author

Sorry @kruai your approval got dismissed again. I actually need the Log_Level for pendo-syncher to be in DEBUG mode for the initial run. We can change it back later on. 😿

kruai
kruai approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me. Still LGTM!

@tahmidefaz
Copy link
Member Author

Merging this as it had 2 approvals earlier.

@tahmidefaz tahmidefaz merged commit 4a03787 into master Jul 16, 2021
thearifismail pushed a commit to thearifismail/insights-host-inventory that referenced this pull request Jul 22, 2021
@tahmidefaz @thearifismail
Adding pendo-syncher deployment config (RedHatInsights#954)
96b1cb9 
* adding pendo-syncher deployment config

* removing double curly-braces

* bump log level to debug for pendo-syncher
thearifismail pushed a commit to thearifismail/insights-host-inventory that referenced this pull request Aug 23, 2021
@tahmidefaz @thearifismail
Adding pendo-syncher deployment config (RedHatInsights#954)
8fee6a1 
* adding pendo-syncher deployment config

* removing double curly-braces

* bump log level to debug for pendo-syncher
@kruai kruai deleted the pendo-syncher-deployment branch February 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruai kruai kruai approved these changes

@thearifismail thearifismail thearifismail left review comments

@ryandillinfelton ryandillinfelton Awaiting requested review from ryandillinfelton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tahmidefaz @thearifismail @kruai