RHCLOUD-32197 Support Case Widget updates #598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhlavac
reviewed
Jun 21, 2024
fhlavac
reviewed
Jun 21, 2024
fhlavac
reviewed
Jun 21, 2024
Comment on lines
+155
to
+190
| const severityMenuItems = ( | ||
| <SelectList> | ||
| <SelectOption | ||
| hasCheckbox | ||
| key={severityTypes.low} | ||
| value={severityTypes.low} | ||
| isSelected={filters.severity.includes(severityTypes.low)} | ||
| > | ||
| {severityTypes.low} | ||
| </SelectOption> | ||
| <SelectOption | ||
| hasCheckbox | ||
| key={severityTypes.normal} | ||
| value={severityTypes.normal} | ||
| isSelected={filters.severity.includes(severityTypes.normal)} | ||
| > | ||
| {severityTypes.normal} | ||
| </SelectOption> | ||
| <SelectOption | ||
| hasCheckbox | ||
| key={severityTypes.high} | ||
| value={severityTypes.high} | ||
| isSelected={filters.severity.includes(severityTypes.high)} | ||
| > | ||
| {severityTypes.high} | ||
| </SelectOption> | ||
| <SelectOption | ||
| hasCheckbox | ||
| key={severityTypes.urgent} | ||
| value={severityTypes.urgent} | ||
| isSelected={filters.severity.includes(severityTypes.urgent)} | ||
| > | ||
| {severityTypes.urgent} | ||
| </SelectOption> | ||
| </SelectList> | ||
| ); |
There was a problem hiding this comment.
This could be definitely deduplicated - generated just from array of severity variants
fhlavac
reviewed
Jun 21, 2024
| setIsStatusExpanded(!isStatusExpanded); | ||
| }; | ||
|
|
||
| const statusMenuItems = ( |
There was a problem hiding this comment.
this could be deduplicated as well
fhlavac
reviewed
Jun 21, 2024
| </SelectList> | ||
| ); | ||
|
|
||
| const toggleGroupItems = ( |
There was a problem hiding this comment.
this could be auto-generated as well
fhlavac
reviewed
Jun 21, 2024
fhlavac
reviewed
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add filtering and sorting to support case widget table.
RHCLOUD-32197
Screenshots
Before:
After:
Checklist ☑️
PR only fixes one issue or story
Change reviewed for extraneous code
UI best practices adhered to
Commits squashed and meaningfully named
All PR checks pass locally (build, lint, test, E2E)