Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-32197 Support Case Widget updates #598

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
295 changes: 295 additions & 0 deletions src/components/widgets/support-case-table-filter.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,295 @@
import React, { ChangeEvent, MouseEvent } from 'react';
import {
Toolbar,
ToolbarContent,
ToolbarFilter,
ToolbarGroup,
ToolbarToggleGroup,
} from '@patternfly/react-core/dist/dynamic/components/Toolbar';
import {
MenuToggle,
MenuToggleElement,
} from '@patternfly/react-core/dist/dynamic/components/MenuToggle';
import {
Select,
SelectList,
SelectOption,
} from '@patternfly/react-core/dist/dynamic/components/Select';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import { severityTypes, statusTypes } from '../../utils/consts';

export const SupportCaseWidgetTableFilter: React.FunctionComponent = () => {
// const [isProductFamilyExpanded, setIsProductFamilyExpanded] =
// React.useState(false);
const [isSeverityExpanded, setIsSeverityExpanded] = React.useState(false);
const [isStatusExpanded, setIsStatusExpanded] = React.useState(false);

const [filters, setFilters] = React.useState({
// productFamily: [],
severity: [''],
status: [''],
});

const onSelect = (
type: string,
event: React.MouseEvent | React.ChangeEvent,
selection: string
) => {
const checked = (event.target as HTMLInputElement).checked;
setFilters((prev) => {
const prevSelections = prev[type];
return {
...prev,
[type]: checked
? [...prevSelections, selection]
: prevSelections.filter((value: string) => value !== selection),
};
});
};

// const onProductFamilySelect = (
// event: React.MouseEvent<Element, MouseEvent> | React.ChangeEvent<Element>,
// selection: string
// ) => {
// onSelect('productFamily', event, selection);
// };

const onSeveritySelect = (
event: MouseEvent | ChangeEvent,
selection: string
) => {
onSelect('severity', event, selection);
};

const onStatusSelect = (
event: MouseEvent | ChangeEvent,
selection: string
) => {
onSelect('status', event, selection);
};

const onDelete = (type: string, id: string) => {
const filterTypes: { [key: string]: string[] } = {
// 'Product Family': filters.productFamily.filter(
// (fil: string) => fil !== id
// ),
Severity: filters.severity.filter((fil: string) => fil !== id),
Status: filters.status.filter((fil: string) => fil !== id),
};
setFilters({
// productFamily:
// type === 'Product Family' ? filterTypes[type] : filters.productFamily,
severity: type === 'Severity' ? filterTypes[type] : filters.severity,
status: type === 'Status' ? filterTypes[type] : filters.status,
});
};

const onDeleteGroup = (type: string) => {
const newFilters = {
// productFamily: type === 'Product Family' ? [] : filters.productFamily,
severity: type === 'Severity' ? [] : filters.severity,
status: type === 'Status' ? [] : filters.status,
};
setFilters(newFilters);
};

// const onProductFamilyToggle = () => {
// setIsProductFamilyExpanded(!isProductFamilyExpanded);
// };

const onSeverityToggle = () => {
setIsSeverityExpanded(!isSeverityExpanded);
};

const onStatusToggle = () => {
setIsStatusExpanded(!isStatusExpanded);
};

const statusMenuItems = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be deduplicated as well

<SelectList>
<SelectOption
hasCheckbox
key={statusTypes.closed}
value={statusTypes.closed}
isSelected={filters.status.includes(statusTypes.closed)}
>
{statusTypes.closed}
</SelectOption>
<SelectOption
hasCheckbox
key={statusTypes.customerWaiting}
value={statusTypes.customerWaiting}
isSelected={filters.status.includes(statusTypes.customerWaiting)}
>
{statusTypes.customerWaiting}
</SelectOption>
<SelectOption
hasCheckbox
key={statusTypes.redHatWaiting}
value={statusTypes.redHatWaiting}
isSelected={filters.status.includes(statusTypes.redHatWaiting)}
>
{statusTypes.redHatWaiting}
</SelectOption>
</SelectList>
);

const severityMenuItems = (
<SelectList>
<SelectOption
hasCheckbox
key={severityTypes.low}
value={severityTypes.low}
isSelected={filters.severity.includes(severityTypes.low)}
>
{severityTypes.low}
</SelectOption>
<SelectOption
hasCheckbox
key={severityTypes.normal}
value={severityTypes.normal}
isSelected={filters.severity.includes(severityTypes.normal)}
>
{severityTypes.normal}
</SelectOption>
<SelectOption
hasCheckbox
key={severityTypes.high}
value={severityTypes.high}
isSelected={filters.severity.includes(severityTypes.high)}
>
{severityTypes.high}
</SelectOption>
<SelectOption
hasCheckbox
key={severityTypes.urgent}
value={severityTypes.urgent}
isSelected={filters.severity.includes(severityTypes.urgent)}
>
{severityTypes.urgent}
</SelectOption>
</SelectList>
);
Comment on lines +137 to +172
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be definitely deduplicated - generated just from array of severity variants


const toggleGroupItems = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be auto-generated as well

<React.Fragment>
<ToolbarGroup variant="filter-group">
{/* <ToolbarFilter
chips={filters.productFamily}
deleteChip={(category, chip) =>
onDelete(category as string, chip as string)
}
deleteChipGroup={(category) => onDeleteGroup(category as string)}
categoryName="Product Family"
>
<Select
aria-label="Product Family"
role="menu"
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle
ref={toggleRef}
onClick={onProductFamilyToggle}
isExpanded={isProductFamilyExpanded}
style={
{
width: '140px',
} as React.CSSProperties
}
>
Product Family
</MenuToggle>
)}
onSelect={onProductFamilySelect}
selected={filters.productFamily}
isOpen={isProductFamilyExpanded}
onOpenChange={(isOpen) => setIsProductFamilyExpanded(isOpen)}
></Select>
</ToolbarFilter> */}
<ToolbarFilter
chips={filters.severity}
deleteChip={(category, chip) =>
onDelete(category as string, chip as string)
}
deleteChipGroup={(category) => onDeleteGroup(category as string)}
categoryName="Severity"
>
<Select
aria-label="Severity"
role="menu"
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle
ref={toggleRef}
onClick={onSeverityToggle}
isExpanded={isSeverityExpanded}
style={
{
width: '140px',
} as React.CSSProperties
}
>
Severity
</MenuToggle>
)}
onSelect={onSeveritySelect}
selected={filters.severity}
isOpen={isSeverityExpanded}
onOpenChange={(isOpen) => setIsSeverityExpanded(isOpen)}
>
{severityMenuItems}
</Select>
</ToolbarFilter>
<ToolbarFilter
chips={filters.status}
deleteChip={(category, chip) =>
onDelete(category as string, chip as string)
}
deleteChipGroup={(category) => onDeleteGroup(category as string)}
categoryName="Status"
>
<Select
aria-label="Status"
role="menu"
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle
ref={toggleRef}
onClick={onStatusToggle}
isExpanded={isStatusExpanded}
style={
{
width: '140px',
} as React.CSSProperties
}
>
Status
</MenuToggle>
)}
onSelect={onStatusSelect}
selected={filters.status}
isOpen={isStatusExpanded}
onOpenChange={(isOpen) => setIsStatusExpanded(isOpen)}
>
{statusMenuItems}
</Select>
</ToolbarFilter>
</ToolbarGroup>
</React.Fragment>
);

const toolbarItems = (
<React.Fragment>
<ToolbarToggleGroup toggleIcon={<FilterIcon />} breakpoint="xl">
{toggleGroupItems}
</ToolbarToggleGroup>
</React.Fragment>
);

return (
<Toolbar
id="toolbar-with-filter"
className="pf-m-toggle-group-container"
collapseListedFiltersBreakpoint="xl"
>
<ToolbarContent>{toolbarItems}</ToolbarContent>
</Toolbar>
);
};
Loading