-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWATCH-1650: Set productID for hosts based on system architecture for QPC hosts #2652
Conversation
Looks reasonable 👍 |
f4ae1d9
to
f4bb9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is in conflict with the changes that were merged in #2604, so some changes are required (see my inline comments).
src/main/java/org/candlepin/subscriptions/tally/facts/FactNormalizer.java
Outdated
Show resolved
Hide resolved
src/test/java/org/candlepin/subscriptions/tally/facts/FactNormalizerTest.java
Outdated
Show resolved
Hide resolved
…tInsights/rhsm-subscriptions into kflahert/swatch-1650-qpc-hosts-bug
…nto kflahert/swatch-1650-qpc-hosts-bug
if (hostFacts.getSystemProfileArch() != null | ||
&& CollectionUtils.isEmpty(hostFacts.getSystemProfileProductIds())) { | ||
switch (hostFacts.getSystemProfileArch()) { | ||
case "x86_64", "i686", "i386": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about these values, is there any documentation or link where to get more information about it? If so, I think it would be really helpful to add a comment here including a reference or link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not aware of any, @mirekdlugosz do you happen to know of any docs around the system arch we could link to for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know, maybe HBI OpenAPI spec file? Or yuptoo.
As I'm on PTO this week, I'm not on position to look for links, sorry. I think it's best to merge as it is and we can add a link in another PR, if we find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If we could find a link where to get more information about the values, it would be perfect. However, I don't think this should be a stopper for this pull request being merged.
Jira issue: SWATCH-1650
Description
When receiving reports from Discovery, we don't receive the specific product_id and must use the system architecture field to determine which RHEL variant it is.
Testing
Setup
Steps
DEV_MODE=true SPRING_PROFILES_ACTIVE=kakfa-queue,worker,api ./gradlew :bootRun
http PUT ":8000/api/rhsm-subscriptions/v1/internal/rpc/tally/snapshots/123" x-rh-swatch-psk:placeholder
Verification