[Do not merge] RHIROS-502 api_version endpoint #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdeotarse
changed the title
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
3 times, most recently
from
3335e1a
to
65dd21d
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
from
65dd21d
to
f9d9df0
Compare
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
from
f9d9df0
to
6953e8a
Compare
saltgen
requested changes
Sep 14, 2023
ros/api/routes.py
Outdated
| api.add_resource(OpenAPISpec, f'/api/ros/{API_VERSION}/openapi.json') | ||
| api.add_resource(CallToActionApi, f'/api/ros/{API_VERSION}/call_to_action') | ||
| api.add_resource(ExecutiveReportAPI, f'/api/ros/{API_VERSION}/executive_report') | ||
| api.add_resource(ApiVersion, f'/api/ros/{API_VERSION}/api_version') |
There was a problem hiding this comment.
@kgaikwad Would like to know your thoughts on global value for API_VERSION.
Do you see this becoming a challenge if endpoints get versioned differently in future?
saltgen
reviewed
Sep 14, 2023
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
from
6953e8a
to
1b7fdfe
Compare
saltgen
requested changes
Sep 15, 2023
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
6 times, most recently
from
d0d7538
to
a5b7fda
Compare
r14chandra
requested changes
Sep 20, 2023
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
2 times, most recently
from
5c1c7bb
to
74abe35
Compare
| @@ -157,3 +157,4 @@ def build_endpoint_url(ep): | |||
| CW_LOGGING_FORMAT = '%(asctime)s - %(levelname)s - %(funcName)s - %(message)s' | |||
| ROS_PROCESSOR_PORT = int(os.getenv("ROS_PROCESSOR_PORT", "8000")) | |||
| ROS_API_PORT = int(os.getenv("ROS_API_PORT", "8000")) | |||
| API_VERSION = 'v1' | |||
There was a problem hiding this comment.
In future we may get more than one api version and both could be supported? can we depend on api paths maybe to get verion and actually show all deployed api versions?
r14chandra
requested changes
Sep 28, 2023
|
\retest |
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
2 times, most recently
from
554b516
to
d12e5bf
Compare
kgaikwad
requested changes
Oct 31, 2023
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
from
d12e5bf
to
0131433
Compare
srdeotarse
force-pushed
the
RHIROS-502-API-version-endpoint
branch
from
0131433
to
5d43fda
Compare
kgaikwad
added
the
STALE
|
Closing this PR as I don't not see any pr updates since long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api_version endpoint 💥
RHIROS-502 [BE] | API Version Endpoint
Add api_version endpoint to return reponse -
branch:
commit_sha:
commit_timestamp:
api_version:
deployed_at:
Endpoint:
/api/ros/v1/api_versionFeel free to remove this section from PR description once done.
Why do we need this change? 💭
Please include the context of this change here.
Documentation update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.