This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Ordering: added Target and Source to Task, removed waiting #84
Merged
agrare
merged 6 commits into
RedHatInsights:master
from
slemrmartin:operations-removed-waiting-for-order-complete
Apr 22, 2020
Merged
Ordering: added Target and Source to Task, removed waiting #84
agrare
merged 6 commits into
RedHatInsights:master
from
slemrmartin:operations-removed-waiting-for-order-complete
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9efd40f
to
dcc321e
Compare
11 tasks
01a1bde
to
c1f1a2f
Compare
Merged
2 tasks
syncrou
reviewed
Apr 20, 2020
def wait_for_job_finished(task_id, job, context) | ||
count = 0 | ||
last_status = nil | ||
timeout_count = POLL_TIMEOUT / SLEEP_POLL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove POLL_TIMEOUT & SLEEP_POLL correct?
@slemrmartin Looks like there is a conflict as well. |
c1f1a2f
to
e6e2e0f
Compare
agrare
approved these changes
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #83
Operation now just orders ServiceOffering and doesn't wait 30 minutes to completing. This functionality is moved to topological_inventory-core.