Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Changed status to string, make specs compatible with latest common gem #304

Merged
merged 1 commit into from
May 19, 2020

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented May 14, 2020

The filter error messages have been fixed
Status for error objects have been converted to string

https://projects.engineering.redhat.com/browse/TPINVTRY-925

The filter error messages have been fixed
Status for error objects have been converted to string
@mkanoor
Copy link
Contributor Author

mkanoor commented May 14, 2020

@syncrou @gmcculloug
Please review

Copy link
Contributor

@lindgrenj6 lindgrenj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with same comment as RedHatInsights/sources-api#219

Opened issue to track: #305

Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@syncrou syncrou merged commit b99ef58 into RedHatInsights:master May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants