Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(VulnerabilityRoutes): Remove duplicate Route element #2079

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

LiorKGOW
Copy link
Member

I have noticed that this Route element is the exact same as the 'cvesPage' one, so this PR removes the duplicate

They both get the same path string and present the same element 'LandingPage' so there is no need for both Routes

@LiorKGOW LiorKGOW self-assigned this Mar 17, 2024
@LiorKGOW LiorKGOW requested a review from a team as a code owner March 17, 2024 16:17
Copy link

jira-linking bot commented Mar 17, 2024

Commits missing Jira IDs:
36cb40e

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (715cd47) to head (36cb40e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   67.84%   67.84%           
=======================================
  Files         131      131           
  Lines        3418     3418           
  Branches     1062     1062           
=======================================
  Hits         2319     2319           
  Misses       1099     1099           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LiorKGOW

@LiorKGOW LiorKGOW merged commit 0e4afcd into RedHatInsights:master Mar 18, 2024
4 checks passed
@LiorKGOW LiorKGOW deleted the remove-duplicate-route branch March 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants