fix(RHINENG-7963): Bug with select all CVEs option on CVEs page #2082
Conversation
|
Referenced Jiras: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
- Coverage 67.84% 67.81% -0.04%
==========================================
Files 131 131
Lines 3418 3424 +6
Branches 1062 1064 +2
==========================================
+ Hits 2319 2322 +3
- Misses 1099 1102 +3 ☔ View full report in Codecov by Sentry. |
LiorKGOW
force-pushed
the
select-all-fix
branch
from
cb6c44b
to
23dfac4
Compare
|
Thank you for the review @bastilian ! This PR is ready for another review 😄 |
LiorKGOW
force-pushed
the
select-all-fix
branch
from
7ae6141
to
aa2b4c5
Compare
|
/retest |
LiorKGOW
force-pushed
the
select-all-fix
branch
2 times, most recently
from
db8ba17
to
8f65962
Compare
|
Thank you for the review ! @mkholjuraev |
LiorKGOW
force-pushed
the
select-all-fix
branch
from
8f65962
to
ebbea52
Compare
If a user has Edge systems in their account, we need to convert the affecting param to be in affectingHostType So, we use hybrid system filter to determine this. - If the user have both Conventional & Edge systems, we convert the affecting params to be in affectingHostType params because affecting is no longer being used in the backend server in this case. - If the user has only Conventional systems, the backend server still uses affecting param, so there is no need for the conversion. Because affecting param is no longer being used in the backend server in the first case, sending it in the request would make the request fail, or in case the request does not fail, it would return bad results Link to issue: https://issues.redhat.com/browse/RHINENG-7963
LiorKGOW
force-pushed
the
select-all-fix
branch
from
ebbea52
to
b8e718e
Compare
|
Rebased and repushed after #2079 was merged to master |
|
@LiorKGOW looks good to me now. Ready to be merged now |
This PR addresses issue #RHINENG-7963
When attempting to "select all" CVEs in the CVEs Page, none are selected
With this code selecting all CVEs works
The reason why this bug occurres:
If a user has Edge systems in their account, we need to convert the affecting param to be in affectingHostType
So, we use hybrid system filter to determine this.
Because affecting param is no longer being used in the backend in the first case, sending it in the request would make the request fail, or in case the request does not fail, it would return bad results
Location where this 'selectAllCVEs' option is located:
