-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspec #232
Inspec #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=====================================
Coverage 54% 54%
=====================================
Files 2 2
Lines 50 50
Branches 3 3
=====================================
Hits 27 27
Misses 23 23 Continue to review full report at Codecov.
|
scripts/master.sh
Outdated
@@ -26,7 +26,8 @@ ansible -i /dev/null \ | |||
detach=true \ | |||
command='/usr/lib/systemd/systemd \ | |||
--system' \ | |||
privileged=true" | |||
capabilities=SYS_ADMIN \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the white space indenting here. These lines don't match the ones above them.
tests/profile.yml
Outdated
value: | ||
- '50000' | ||
|
||
jenkins_plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list will change for every different version of Jenkins. Are we sure we want to hard-code it into the test instead of base it off the version of Jenkins in an external file, the way we do with the main plugin list? This could get to be a very noisy file, otherwise.
@greg-hellings, I changed what you asked, anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once RedHatQE/jenkins-profile#1 will be merged, I will update the PR to use the main repository of jenkins-profile.
This enables Inspec testing for Cinch that will verify the end deployment mets the requirements. This is initial setup and doesn't include all required testing but enough to get started.