Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspec #232

Merged
merged 4 commits into from
Jun 26, 2018
Merged

Inspec #232

merged 4 commits into from
Jun 26, 2018

Conversation

abraverm
Copy link
Contributor

Once RedHatQE/jenkins-profile#1 will be merged, I will update the PR to use the main repository of jenkins-profile.

This enables Inspec testing for Cinch that will verify the end deployment mets the requirements. This is initial setup and doesn't include all required testing but enough to get started.

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #232   +/-   ##
=====================================
  Coverage      54%    54%           
=====================================
  Files           2      2           
  Lines          50     50           
  Branches        3      3           
=====================================
  Hits           27     27           
  Misses         23     23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4925888...b72ef8e. Read the comment docs.

@@ -26,7 +26,8 @@ ansible -i /dev/null \
detach=true \
command='/usr/lib/systemd/systemd \
--system' \
privileged=true"
capabilities=SYS_ADMIN \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the white space indenting here. These lines don't match the ones above them.

value:
- '50000'

jenkins_plugins:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list will change for every different version of Jenkins. Are we sure we want to hard-code it into the test instead of base it off the version of Jenkins in an external file, the way we do with the main plugin list? This could get to be a very noisy file, otherwise.

@abraverm
Copy link
Contributor Author

@greg-hellings, I changed what you asked, anything else?

Copy link
Contributor

@greg-hellings greg-hellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abraverm abraverm merged commit 3dfaf60 into RedHatQE:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants