Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set strict-naming=false for hatch #240

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

mshriver
Copy link
Collaborator

@mshriver mshriver commented Jul 3, 2023

This will build a wheel using the project name and unblock warehouse naming limitations from #230

Alternative approach to #239


❯ hatch build
[sdist]
dist/widgetastic.core-1.0.4.dev1+gc4c81fe.tar.gz

[wheel]
dist/widgetastic.core-1.0.4.dev1+gc4c81fe-py3-none-any.whl


FIXES #230

wheel and sdist target options for strict-naming will build a wheel using the project name
and unblock warehouse naming limitations from RedHatQE#230
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #240 (92e99e8) into master (c65c167) will not change coverage.
The diff coverage is n/a.

❗ Current head 92e99e8 differs from pull request most recent head c4c81fe. Consider uploading reports for the commit c4c81fe to get more accurate results

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          18       18           
  Lines        2570     2570           
=======================================
  Hits         2222     2222           
  Misses        348      348           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mshriver mshriver added the bug label Jul 3, 2023
@mshriver mshriver merged commit 45d3117 into RedHatQE:master Jul 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI upload filename has to match project name
1 participant