Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: typing_extensions #245

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 11, 2023

Summary

This pull request removes the unused dependency typing_extensions from the setup.cfg configuration file. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The typing_extensions library was originally introduced to the project in #192 for its use in the src/widgetastic/types.py file. However, as of now, the said file (src/widgetastic/types.py) has been deleted, and the dependency appears to be unused within the source code, while it continues to be listed in the project's dependency files.
Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.

Changes

  • Removed the typing_extensions dependency from setup.cfg.

Impact

  • Reduced Package Size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified Dependency Tree: Fewer dependencies make the project easier to maintain and can speed up installation.

@gdrosos
Copy link
Contributor Author

gdrosos commented Aug 27, 2023

Hello @digitronik, @mshriver, @LightOfHeaven1994

I hope this message finds you all well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as maintainers would greatly contribute to our research efforts.

Could you please take a moment to review the changes proposed on this PR? Your input would be highly valuable to us.

Thank you for your consideration!

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #245 (aa1d41e) into master (2c2843e) will not change coverage.
The diff coverage is n/a.

❗ Current head aa1d41e differs from pull request most recent head 886e6df. Consider uploading reports for the commit 886e6df to get more accurate results

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          18       18           
  Lines        2570     2570           
=======================================
  Hits         2222     2222           
  Misses        348      348           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@LightOfHeaven1994 LightOfHeaven1994 merged commit 59e2a82 into RedHatQE:master Aug 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants