Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ouia: use "contains" in xpath locator #248

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

jrusz
Copy link
Contributor

@jrusz jrusz commented Oct 4, 2023

This allows to make widgetastic.patternfly5 ouia widgets backwards compatibl with PF4.

@jrusz
Copy link
Contributor Author

jrusz commented Oct 4, 2023

@digitronik Hi, can you review this please? (For some reason I can't add reviewers)

@digitronik
Copy link
Member

@jrusz unit tests ^^

This allows to make widgetastic.patternfly5 ouia widgets backwards
compatibl with PF4.
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #248 (bfdbe1c) into master (4366f0d) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head bfdbe1c differs from pull request most recent head 6151030. Consider uploading reports for the commit 6151030 to get more accurate results

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          18       18           
  Lines        2570     2570           
=======================================
  Hits         2222     2222           
  Misses        348      348           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/widgetastic/ouia/__init__.py 92.30% <ø> (ø)

@jrusz
Copy link
Contributor Author

jrusz commented Oct 10, 2023

@jrusz unit tests ^^

Fixed :)

@digitronik digitronik merged commit ed02ea7 into RedHatQE:master Oct 10, 2023
14 checks passed
@jrusz jrusz deleted the ouia-update branch October 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants