Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dune #176

Merged
merged 7 commits into from
Jul 23, 2018
Merged

Migrate to dune #176

merged 7 commits into from
Jul 23, 2018

Conversation

jonsterling
Copy link
Collaborator

@jonsterling jonsterling commented Jul 23, 2018

Close #175

Dune reports more warnings than jbuilder did (maybe that was a bug?), so now I fixed a bunch of warnings that it emitted.

I think in order to get your local environment updated, you just run opam upgrade and follow your nose. let me know if there are any problems.

@jonsterling jonsterling requested a review from favonia July 23, 2018 08:41
Copy link
Collaborator

@favonia favonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will assume travis works.

@jonsterling jonsterling merged commit 37dbdc3 into master Jul 23, 2018
@jonsterling jonsterling deleted the migrate-to-dune branch July 23, 2018 10:30
@favonia
Copy link
Collaborator

favonia commented Jul 23, 2018

Dune reports more warnings than jbuilder did (maybe that was a bug?), so now I fixed a bunch of warnings that it emitted.

There is not really any bug. Dune is the new name of jbuilder.

@jonsterling
Copy link
Collaborator Author

@favonia Haha, what I meant is that maybe it was a bug that jbuilder was not emitting the same number of warnings as dune (the new version of jbuilder) does now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build to use Dune
2 participants