Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade volto 17.3.0 su v3 #382

Merged
merged 26 commits into from
Nov 21, 2023
Merged

Upgrade volto 17.3.0 su v3 #382

merged 26 commits into from
Nov 21, 2023

Conversation

mamico
Copy link

@mamico mamico commented Oct 29, 2023

@mamico mamico marked this pull request as ready for review November 3, 2023 08:32
@mamico mamico requested a review from pnicolli November 3, 2023 08:32
@giuliaghisini
Copy link

@mamico
verificherei anche queste cose che avevo cambiato nella pr del v2, soprattutto per le sizes delle immagini e le classi, che avevo provato sui vari dispositivi (https://github.com/RedTurtle/design-comuni-plone-theme/pull/325/files):

  • src/components/ItaliaTheme/Blocks/Listing/CardWithSlideUpTextTemplate.jsx
  • src/components/ItaliaTheme/Blocks/Listing/CompleteBlockLinksTemplate.jsx
  • src/components/ItaliaTheme/Blocks/Listing/GridGalleryTemplate.jsx
  • src/components/ItaliaTheme/Blocks/Listing/InEvidenceTemplate.jsx
  • src/components/ItaliaTheme/Blocks/Listing/SliderTemplate.jsx
  • src/components/ItaliaTheme/Blocks/Listing/SmallBlockLinksTemplate.jsx
  • src/components/ItaliaTheme/Cards/CardPersona.jsx
  • src/components/ItaliaTheme/View/Commons/ContentImage.jsx
  • src/components/ItaliaTheme/View/Commons/Events.jsx e verificare anche quella dispatch commentata per gli eventi figli
  • src/components/ItaliaTheme/View/Commons/Gallery.jsx
  • src/components/ItaliaTheme/View/Commons/LocationItem.jsx
  • src/components/ItaliaTheme/View/Commons/PageHeader/PageHeader.jsx
  • src/components/ItaliaTheme/View/Commons/Sponsors.jsx
  • src/components/ItaliaTheme/View/Commons/VenuesSmall.jsx
  • src/components/ItaliaTheme/View/PageView/PageView.jsx
  • src/components/ItaliaTheme/View/PaginaArgomentoView/PaginaArgomentoView.jsx
  • theme/ItaliaTheme/Blocks/_cardWithImageAndInEvidence.scss
  • theme/ItaliaTheme/Blocks/_completeBlockLinkstemplate.scss
  • theme/ItaliaTheme/Blocks/_ctaBlock.scss
  • theme/ItaliaTheme/Views/_common.scss
  • theme/ItaliaTheme/_main.scss

@mamico
Copy link
Author

mamico commented Nov 8, 2023

@mamico verificherei anche queste cose che avevo cambiato nella pr del v2, soprattutto per le sizes delle immagini e le classi, che avevo provato sui vari dispositivi (https://github.com/RedTurtle/design-comuni-plone-theme/pull/325/files):

Posso guardarci e applicare le tue stesse modifiche. Ma il concetto che ho seguito è stato quello di cambiare solo l'utilizzo della componente Image, tu qui invece mi sa che hai fatto fix legate ad altro (ad esemmpio il cambio da teaser a large qui: https://github.com/RedTurtle/design-comuni-plone-theme/pull/325/files#diff-b3cbaaa828ce1d057ea8cb5b527fe1b8eb6b9b1c6cb18763458fa3896a56e848L48).

@giuliaghisini
Copy link

@mamico verificherei anche queste cose che avevo cambiato nella pr del v2, soprattutto per le sizes delle immagini e le classi, che avevo provato sui vari dispositivi (https://github.com/RedTurtle/design-comuni-plone-theme/pull/325/files):

Posso guardarci e applicare le tue stesse modifiche. Ma il concetto che ho seguito è stato quello di cambiare solo l'utilizzo della componente Image, tu qui invece mi sa che hai fatto fix legate ad altro (ad esemmpio il cambio da teaser a large qui: https://github.com/RedTurtle/design-comuni-plone-theme/pull/325/files#diff-b3cbaaa828ce1d057ea8cb5b527fe1b8eb6b9b1c6cb18763458fa3896a56e848L48).

si ho fatto anche altri fix perchè intanto che facevo cose vedevo cose rotte

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/prs.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/ItaliaTheme/View/Commons/Events.jsx Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@pnicolli pnicolli changed the base branch from main to 11-alpha November 21, 2023 16:29
@pnicolli pnicolli merged commit cef3f09 into 11-alpha Nov 21, 2023
3 checks passed
@pnicolli pnicolli deleted the upgrade_volto_17.3_v3 branch November 21, 2023 16:30
pnicolli added a commit that referenced this pull request Dec 18, 2023
* fix: change image component in ctablock

* ci: upgrade volto

* fix: change image component in  hlcontent

* fix: change image component listingimage

* fix: change image component subevents

* fix: change image component gallery

* fix: change image component GenericCard

* fix: change image component

* fix: change image component (sponsor + venuesmall)

* fix: change image component

* fix: minutes with 00 format

* docs: rimosso commento obsoleto

* fix: review giulia

* fix: review giulia

* fix: scroll position on h2 .visually-hidden

* feat: upgrade to volto 17.5.0

* docs: fix order

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* fix: review piero

* fix: sponsor evento without image

* fix: gallery preview

---------

Co-authored-by: Giulia Ghisini <giulia.ghisini@redturtle.it>
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
pnicolli added a commit that referenced this pull request Mar 4, 2024
…m components, fixed layout and invalid field messages and select from drop-down menu (#556)

* feat!: upgrade to volto 17.5.0 (#382)

* fix: change image component in ctablock

* ci: upgrade volto

* fix: change image component in  hlcontent

* fix: change image component listingimage

* fix: change image component subevents

* fix: change image component gallery

* fix: change image component GenericCard

* fix: change image component

* fix: change image component (sponsor + venuesmall)

* fix: change image component

* fix: minutes with 00 format

* docs: rimosso commento obsoleto

* fix: review giulia

* fix: review giulia

* fix: scroll position on h2 .visually-hidden

* feat: upgrade to volto 17.5.0

* docs: fix order

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* fix: review piero

* fix: sponsor evento without image

* fix: gallery preview

---------

Co-authored-by: Giulia Ghisini <giulia.ghisini@redturtle.it>
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* feat!: upgrade to design-react-kit 5.0.0-1 and bootstrap-italia 2.6.1 (#407)

* fix: change image component in ctablock

* ci: upgrade volto

* fix: change image component in  hlcontent

* fix: change image component listingimage

* fix: change image component subevents

* fix: change image component gallery

* fix: change image component GenericCard

* fix: change image component

* fix: change image component (sponsor + venuesmall)

* fix: change image component

* fix: minutes with 00 format

* docs: rimosso commento obsoleto

* fix: review giulia

* fix: review giulia

* fix: scroll position on h2 .visually-hidden

* feat: upgrade to volto 17.5.0

* docs: fix order

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* fix: review piero

* fix: sponsor evento without image

* fix: gallery preview

* feat: upgrade to design-react-kit 5.0.0-1 and bootstrap-italia 2.6.1

* fix: fix for new design-react-kit

* fix: card image height changed like bootstrap-italia templates

* fix: revert  card image height changed like bootstrap-italia templates

* fix: stepper style ul

* fix. pr fixes

* chore: updated locales

* fix: screen reader for SearchModal

* fix: screen reader in SearchModal

* chore: update dependencies

* fix: bootstrap imports

* fix: locales

* fix: duplicate css

---------

Co-authored-by: Mauro Amico <mauro.amico@gmail.com>
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
Co-authored-by: Piero Nicolli <piero.nicolli@redturtle.it>

* chore: release v11.0.0-alpha.0

* feat!: card image height from newest bootstrap-italia version (#406)

* fix: change image component in ctablock

* ci: upgrade volto

* fix: change image component in  hlcontent

* fix: change image component listingimage

* fix: change image component subevents

* fix: change image component gallery

* fix: change image component GenericCard

* fix: change image component

* fix: change image component (sponsor + venuesmall)

* fix: change image component

* fix: minutes with 00 format

* docs: rimosso commento obsoleto

* fix: review giulia

* fix: review giulia

* fix: scroll position on h2 .visually-hidden

* feat: upgrade to volto 17.5.0

* docs: fix order

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* fix: review piero

* fix: sponsor evento without image

* fix: gallery preview

* feat: upgrade to design-react-kit 5.0.0-1 and bootstrap-italia 2.6.1

* fix: fix for new design-react-kit

* fix: card image height changed like bootstrap-italia templates

* fix: revert  card image height changed like bootstrap-italia templates

* fix: revert text-secondary class

* fix: stepper style ul

* fix. pr fixes

* chore: updated locales

* fix: screen reader for SearchModal

* fix: screen reader in SearchModal

* chore: update dependencies

* fix: bootstrap imports

* chore: release v11.0.0-alpha.0

* feat:change image card height

---------

Co-authored-by: Mauro Amico <mauro.amico@gmail.com>
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
Co-authored-by: Piero Nicolli <piero.nicolli@redturtle.it>

* fix: listing block card-slide-text-template read-more alignment (#416)

* chore: release v11.0.0-alpha.1

* fix: image size in listing

* fix: update volto-editablefooter to 5.0.3

* fix: gallery component for ct views breaking with newer backend versions (#422)

* fix: background image for NumbersBlock and Countdown block (#423)

* fix: background image for NumbersBlock and Countdown block

* fix: tests

* chore: release v11.0.0-alpha.2

* style: fixed input form style

* docs: updated release.md and changelog files

* fix: remain in form if there's errors on sending form

* chore: updated input type file with aria-invalid and required attributes

* chore: updated formView with legend tag for required fields

* chore: updated locales and release.md

* feat: updated volto-form-block v3.3.1 and added new features in custom components

---------

Co-authored-by: Mauro Amico <mauro.amico@gmail.com>
Co-authored-by: Giulia Ghisini <giulia.ghisini@redturtle.it>
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
Co-authored-by: Giulia Ghisini <51911425+giuliaghisini@users.noreply.github.com>
Co-authored-by: Piero Nicolli <piero.nicolli@redturtle.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants