Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally add image_scales and image_field in Summary serializer. #210

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Nov 1, 2023

No description provided.

@mamico mamico requested a review from cekk November 1, 2023 19:54
@coveralls
Copy link

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6782321440

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 35 of 40 (87.5%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on image_scales_in_summary at 74.842%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/design/plone/contenttypes/restapi/serializers/modulo.py 1 2 50.0%
src/design/plone/contenttypes/restapi/serializers/punto_di_contatto.py 1 2 50.0%
src/design/plone/contenttypes/restapi/serializers/summary.py 25 28 89.29%
Totals Coverage Status
Change from base Build 6782304980: 74.8%
Covered Lines: 3088
Relevant Lines: 4126

💛 - Coveralls

@mamico mamico merged commit 75630d6 into main Nov 7, 2023
8 checks passed
@mamico mamico deleted the image_scales_in_summary branch November 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants