Allow snap to write to user's homedir #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Reden snap (added in pull request #29) has no access to the user's homedir. This is annoying as it means users can't backup their wallet file outside of the confined snap directory.
We don't want to make it difficult to backup your wallet.
This pull request adds homedir read/write access for the Reden snap. The Reden Qt data directory is still the default common directory within the snap but, with this change, you can choose to store it somewhere in your homedir as well. I feel this has the best of both worlds: it's standard snap behavior (doesn't pollute anything outside the snap unless you tell it to) but still allows users to change the default at bootstrap.
Always backup your wallet.dat file in a save location, it contains all the secrets needed to restore your wallet if something goes wrong!
References #31 (background discussion on the expected snap behavior).