Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the TAG docs based on repeated questions (#1923) #1928

Closed
wants to merge 2 commits into from

Conversation

emmanuelkeller
Copy link
Contributor

@emmanuelkeller emmanuelkeller commented Mar 29, 2021

(Backport branch 2.0)

  • Refactor the TAG docs based on repeated questions

  • Fix an FT.CREATE example

  • Fix typo

  • Fix a couple of typos

* Refactor the TAG docs based on repeated questions

* Fix an FT.CREATE example

* Fix typo

* Fix a couple of typos
Copy link
Contributor

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment about stopwords.

docs/Tags.md Outdated
```

**NOTE:** Stop words are words that are so common that a search engine ignores them. We have a dedicated page about [stop words in RediSearch](https://oss.redislabs.com/redisearch/Stopwords/#default_stop-word_list) if you would like to learn more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have changed this and tag fields do index stopword.
See PR #1668

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashtul What version included that change? I'm on 2.0.5 and still see the behavior in this document. E.g. (in this example, author_ids is a TAG field):

127.0.0.1:6379> FT.SEARCH books-idx "@author_ids:{ to be }"
(error) Syntax error at offset 20 near be
127.0.0.1:6379> FT.SEARCH books-idx "@author_ids:{ to\\ be }"
1) (integer) 0

CC @emmanuelkeller

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@abrookins abrookins Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be an issue in 2.0.6:

1:M 22 Apr 2021 17:24:56.508 * <search> RediSearch version 2.0.6 (Git=v2.0.4-55-gb0db8b2e)
127.0.0.1:6379> FT.SEARCH books-idx "@author_ids:{ to be }"                                                                                             
(error) Syntax error at offset 20 near be
127.0.0.1:6379> FT.SEARCH books-idx "@author_ids:{ to\\ be }"                                                                                           
1) (integer) 0

@emmanuelkeller @ashtul

@rafie rafie deleted the refactor_tag_bp_2_0_docs branch January 15, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants