add STOPWORD to TAGLIST in query parser #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
==========================================
- Coverage 81.77% 81.77% -0.01%
==========================================
Files 146 146
Lines 20952 20952
==========================================
- Hits 17134 17133 -1
- Misses 3818 3819 +1
Continue to review full report at Codecov.
|
rafie
approved these changes
Nov 23, 2020
ashtul
added a commit
that referenced
this pull request
Dec 3, 2020
* add STOPWORD to TAGLIST * use templete for parser.c (cherry picked from commit fda9566)
ashtul
added a commit
that referenced
this pull request
Dec 3, 2020
ashtul
added a commit
that referenced
this pull request
Dec 27, 2020
* add STOPWORD to TAGLIST * use templete for parser.c (cherry picked from commit fda9566)
ashtul
added a commit
that referenced
this pull request
Jan 21, 2021
* Replace assert on limit of sortable fields (#1757) (cherry picked from commit 5f7f105) * Enforce 0 value for count reducer (#1745) * Enforce 0 values for count * fix rstest * fix for centos (cherry picked from commit 0ab57d6) * feat: Add hindi snowball stemmer (cherry picked from commit eac3594) * Update snowball (#1708) * Update snowball * use rm allocator (cherry picked from commit b3e86c2) * [fix] parsing float scientific representation - Issue 1208 (#1225) * fix ragel file * test * more precise (cherry picked from commit 5eb145b) * add STOPWORD to TAGLIST in query parser (#1668) * add STOPWORD to TAGLIST * use templete for parser.c (cherry picked from commit fda9566) * Revert "Update snowball (#1708)" This reverts commit b2b49ea. * Revert "feat: Add hindi snowball stemmer" This reverts commit 4ee9026. * return error for ft.alter w/o schema (#1754) * return error for ft.alter w/o schema * Add test (cherry picked from commit 97f9d94) * minTermPrefix & maxPrefixExpansions (#1774) * minTermPrefix & maxPrefixExpansions * fix rstest (cherry picked from commit afc7e3c) * Fix depth issue for score explain (cherry picked from commit acdb772) * Update Configuring.md * Revert "Update Configuring.md" This reverts commit 96e5a00. * fix slop when no diff between offsets + test (#1605) unclear why there (cherry picked from commit 9de8286) * use pointer instead of struct (#1591) Co-authored-by: Rafi Einstein <rafi@redislabs.com> (cherry picked from commit 56864b3) * Sortby for non-sortable fields issue 1540 (#1574) * sortby for non sortable fields issue 1540 (cherry picked from commit 1cd66d8) * explicit error for EXPLAINSCORE w/o WITHSCORES (#1550) * explicit error for EXPLAINSCORE w/o WITHSCORES * per review (cherry picked from commit 21b3d7f) * avoid loop at DocTable_Set (#1498) * avoid loop at DocTable_Set (cherry picked from commit 06f52bf) * Add test for LIMIT offset num (#1672) * test * updated test for coordinator (cherry picked from commit 685929a) * upgrade mkdocs (#1755) (cherry picked from commit 84529a6) * Fixed testCriteriaTesterDeactivated on macOS (#1660) (cherry picked from commit 1e25d9e) * fix tests * Revert "Add test for LIMIT offset num (#1672)" This reverts commit 8c6be73. * Insert to suggest heap only if score larger than minimum - (#1689) (cherry picked from commit ac0973d) * Fix wrong arity for syndump (#1570) (cherry picked from commit afbc834) * skip or remove unrelated tests * bump version to 1.6.15 * Fix stats report (#1517) * Fix stats report * remove unneeded ';' * Update lastblkBytesCollected correctly (cherry picked from commit 9c67a13) * remove loom and rax - unused (#1521) Co-authored-by: Rafi Einstein <rafi@redislabs.com> (cherry picked from commit be7d847) * Fixed build instructions (#1535) (cherry picked from commit fef72dc) * See RED-47209, fix crash when using WITHSORTKEYS without SORTBY (#1572) (cherry picked from commit 11a6218) * Prevent multiple sortby steps (#1614) (cherry picked from commit 89095a6) * added thread local support to rwlock (#1328) (#1643) * added thread local support to rwlock * fix msan failure * fix msan failure * fix compilation error * fix compilation error * fix msan failure * review fixes (cherry picked from commit 5977ef0) Co-authored-by: Joe Paul <joeirimpan@gmail.com> Co-authored-by: Emmanuel Keller <74923777+emmanuelkeller@users.noreply.github.com> Co-authored-by: Emmanuel Keller <emmanuel.keller@redislabs.com> Co-authored-by: Meir Shpilraien (Spielrein) <meir@redislabs.com> Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: Rafi Einstein <rafi@redislabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser differentiates between all terms and stopwords before creating lists of terms. Therefore stopword has to be added to a tag-list explicitly.
fix #1667
fix #984
We had more issues (#1237 and #1294) where users emptied their stoplist.