[BUG] Use local GC ctx in periodic callback #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafie
previously approved these changes
Aug 4, 2022
|
This pull request introduces 1 alert when merging f711348 into d5a17d3 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7c17188 into d5a17d3 - view on LGTM.com new alerts:
|
oshadmi
reviewed
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
+ Coverage 81.92% 81.94% +0.01%
==========================================
Files 180 180
Lines 29264 29452 +188
==========================================
+ Hits 23974 24133 +159
- Misses 5290 5319 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oshadmi
requested review from
rafie and
MeirShpilraien
and removed request for
oshadmi
src/gc.c
Outdated
| RedisModuleCtx* ctx; | ||
| switch (RSGlobalConfig.gcPolicy) { | ||
| case GCPolicy_Fork: | ||
| ctx = ((ForkGC *)(gc->gcCtx))->ctx; |
There was a problem hiding this comment.
I believe there is no harm in creating ThreadSafeCtx anyway each time.
There was a problem hiding this comment.
Replaced with RedisModule_GetThreadSafeContext and freed.
Let's push this.
| @@ -79,7 +79,7 @@ static void threadCallback(void* data) { | |||
| GCTask* task= data; | |||
| GCContext* gc = task->gc; | |||
| RedisModuleBlockedClient* bc = task->bClient; | |||
| RedisModuleCtx* ctx = RSDummyContext; | |||
| RedisModuleCtx* ctx = RedisModule_GetThreadSafeContext(NULL); | |||
|
|
|||
| if (gc->stopped) { | |||
| // if the client is blocked, lets release it | |||
MeirShpilraien
approved these changes
Aug 5, 2022
rafie
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Use local GC ctx and add logs * get the right ctx * per review * add test * Skip GC on cluster and temporarily comment out part of testMultiTextNested * streamline code * test fixed in #2967 * fix leak Co-authored-by: oshadmi <omer.shadmi@redislabs.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> (cherry picked from commit 3f7c8db)
ashtul
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Use local GC ctx and add logs * get the right ctx * per review * add test * Skip GC on cluster and temporarily comment out part of testMultiTextNested * streamline code * test fixed in #2967 * fix leak Co-authored-by: oshadmi <omer.shadmi@redislabs.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> (cherry picked from commit 3f7c8db)
ashtul
pushed a commit
that referenced
this pull request
Aug 7, 2022
* Use local GC ctx and add logs * get the right ctx * per review * add test * Skip GC on cluster and temporarily comment out part of testMultiTextNested * streamline code * test fixed in #2967 * fix leak Co-authored-by: oshadmi <omer.shadmi@redislabs.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> (cherry picked from commit 3f7c8db)
oshadmi
added a commit
that referenced
this pull request
Aug 8, 2022
* Use local GC ctx and add logs * get the right ctx * per review * add test * Skip GC on cluster and temporarily comment out part of testMultiTextNested * streamline code * test fixed in #2967 * fix leak Co-authored-by: oshadmi <omer.shadmi@redislabs.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
RSDummeyCtxwithAutoMemorycaused memory corruption as Redis maintains a list of freed pointers.When RM_RetainString is called on a pointer in the auto memory pointer list, Redis does not increase the ref count, which causes
double free.MOD-3951
Fixes #2766