-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOD-6540: Support EMPTY indexing for TEXT fields #4622
MOD-6540: Support EMPTY indexing for TEXT fields #4622
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## razmon-feature_empty_text_indexing #4622 +/- ##
======================================================================
+ Coverage 85.79% 85.90% +0.11%
======================================================================
Files 188 188
Lines 33121 33089 -32
======================================================================
+ Hits 28417 28426 +9
+ Misses 4704 4663 -41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 Very nice! A few more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ Minor comments
Describe the changes in the pull request
Currently we discard empty strings for TEXT fields in our index, i.e., we don't index them and don't allow querying for them as well.
This PR adds the support of indexing and querying for such empty strings (
''
) for TEXT fields.This is done by adding the
ISEMPTY
keyword in the index creation for the desired TEXT field, as such:Then, querying for such empty values is done via the
isempty(@my_field)
syntax in the query, as such:This syntax is compatible with all other query constructs, just as any other first-class citizen.
Some cleaning and commenting was done as well,
Mark if applicable