Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] MOD-6540: Support EMPTY indexing for TEXT fields (#4622) (#4637) #4663

Merged
merged 1 commit into from
May 23, 2024
Merged

[2.10] MOD-6540: Support EMPTY indexing for TEXT fields (#4622) (#4637) #4663

merged 1 commit into from
May 23, 2024

Conversation

raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented May 22, 2024

CP of #4622 to 2.10

@raz-mon
MOD-6540: Support EMPTY indexing for TEXT fields (#4622) (#4637)
7fe2d9c 
* MOD-6540: Support EMPTY indexing for TEXT fields (#4622)

* Resolving conflicts

* Updatet commands.json file
@raz-mon raz-mon requested a review from oshadmi May 22, 2024 11:27
@codecov Codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 90.14085% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.08%. Comparing base (6aad837) to head (7fe2d9c).

Files Patch % Lines
src/spec.c 93.50% 5 Missing ⚠️
src/inverted_index.c 0.00% 3 Missing ⚠️
src/doc_table.c 50.00% 1 Missing ⚠️
src/document.c 80.00% 1 Missing ⚠️
src/json.c 66.66% 1 Missing ⚠️
src/numeric_index.c 50.00% 1 Missing ⚠️
src/query.c 91.66% 1 Missing ⚠️
src/query_optimizer.c 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.10    #4663      +/-   ##
==========================================
+ Coverage   85.99%   86.08%   +0.08%     
==========================================
  Files         190      190              
  Lines       34514    34490      -24     
==========================================
+ Hits        29681    29691      +10     
+ Misses       4833     4799      -34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raz-mon raz-mon requested a review from nafraf May 22, 2024 13:07
@raz-mon raz-mon enabled auto-merge May 22, 2024 16:16
@raz-mon raz-mon added this pull request to the merge queue May 23, 2024
Merged via the queue into 2.10 with commit 21b4f6a May 23, 2024
10 checks passed
@raz-mon raz-mon deleted the razmon-cp_2.10_empty_text branch May 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi approved these changes

@nafraf nafraf Awaiting requested review from nafraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raz-mon @oshadmi