add new command EXPIRE #167

Issif · 2022-06-29T14:17:43Z

For my project, falcosidekick-ui I use redisearch as storage for the events, it works really well but the community asked me to add a TTL to keys. It's not currently possible in this SDK, so updated the Document structure with a new field TTL and created a method SetTTL. I tested my fork in my program, and it works

127.0.0.1:6379> keys *
1) "event:1656512211824943"
2) "event:1656512211824021"
127.0.0.1:6379> TTL event:1656512211824021
(integer) 91
127.0.0.1:6379> TTL event:1656512211824021
(integer) 85

Signed-off-by: Issif issif+github@gadz.org

Signed-off-by: Issif <issif+github@gadz.org>

chayim · 2022-07-13T08:50:57Z

redisearch/document.go

@@ -70,6 +71,12 @@ func (d Document) Set(name string, value interface{}) Document {
 	return d
 }

+// SetTTL sets the ttl in the document
+func (d Document) SetTTL(ttl int) Document {


I can definitely see the value... But perhaps we should at least set a default TTL of -1 during the New.

Without the set, it's by default to -1

Correct - I just prefer being explicit.

I'm in holidays, I'll update this PR when I'm back

I thought and I think we should let the code like this, in this current setup, if the TTL is not set, we follow the Redis default behavior and the keys have no expiration, if we set the TTL, a second command is run to add an expiration to the key. It means, if we don't need to set the TTL we run only 1 command and not 2. For huge workload, it can be useful to avoid to run 2 commands when it's not necessary. wdyt?