Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valgrind fixes #462

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Valgrind fixes #462

merged 4 commits into from
Sep 23, 2020

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Sep 22, 2020

This PR sanitizes memory access on master in view of 1.2.0

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #462 into master will decrease coverage by 0.05%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   75.00%   74.94%   -0.06%     
==========================================
  Files          21       21              
  Lines        4916     4910       -6     
==========================================
- Hits         3687     3680       -7     
- Misses       1229     1230       +1     
Impacted Files Coverage Δ
src/dag.c 88.49% <85.71%> (-0.09%) ⬇️
src/run_info.c 87.50% <100.00%> (-0.82%) ⬇️
src/tensor.c 83.24% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a939fc9...376da73. Read the comment docs.

@lantiga lantiga requested review from rafie, filipecosta90 and DvirDukhan and removed request for rafie September 22, 2020 19:49
@lantiga lantiga merged commit ba93a39 into master Sep 23, 2020
@lantiga lantiga deleted the valgrind-fixes branch September 23, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants