Remove use of implementation detail __compar_fn_t #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TopK_List uses __compar_fn_t to cast cmpHeapBucket to the correct signature and fails to compile using implementations without the __compar_fn_t typedef. This patch makes that cast unnecessary. Signed-off-by: Ted Lyngmo <ted@lyncon.se>
|
|
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 85.60% 85.62% +0.01%
==========================================
Files 10 10
Lines 1841 1843 +2
==========================================
+ Hits 1576 1578 +2
Misses 265 265 |
ashtul
approved these changes
Sep 15, 2021
ashtul
pushed a commit
that referenced
this pull request
Feb 23, 2022
TopK_List uses __compar_fn_t to cast cmpHeapBucket to the correct signature and fails to compile using implementations without the __compar_fn_t typedef. This patch makes that cast unnecessary. Signed-off-by: Ted Lyngmo <ted@lyncon.se> (cherry picked from commit 100c48f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopK_Listuses__compar_fn_tto castcmpHeapBucketto the correctsignature and fails to compile using implementations without the
__compar_fn_ttypedef. This patch makes that cast unnecessary.Signed-off-by: Ted Lyngmo ted@lyncon.se