Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rebloom.c #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update rebloom.c #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rebloom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,11 +1340,11 @@
REBLOOM_VERSION_MINOR, REBLOOM_VERSION_PATCH, REDISBLOOM_GIT_SHA);

if (argc == 1) {
RedisModule_Log(ctx, "notice", "Found empty string. Assuming ramp-packer validation");
// Hack for ramp-packer which gives us an empty string.
size_t tmp;
RedisModule_StringPtrLen(argv[0], &tmp);
if (tmp == 0) {
RedisModule_Log(ctx, "notice", "Found empty string. Assuming ramp-packer validation");

Check warning on line 1346 in src/rebloom.c

View check run for this annotation

Codecov / codecov/patch

src/rebloom.c#L1346 

Added line #L1346 was not covered by tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a test be added?

// Hack for ramp-packer which gives us an empty string.
argc = 0;
}
}
Expand Down
Loading