Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling scalars in JSON.GET #301

Merged
merged 3 commits into from
Jul 12, 2023
Merged

handling scalars in JSON.GET #301

merged 3 commits into from
Jul 12, 2023

Conversation

slorello89
Copy link
Contributor

Fixes #283 - adds support for scalar types beyond strings (booleans and numbers)

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #301 (8886c47) into master (ff2fb5f) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   94.67%   94.88%   +0.20%     
==========================================
  Files          39       39              
  Lines        2686     2696      +10     
  Branches       80       80              
==========================================
+ Hits         2543     2558      +15     
+ Misses        132      128       -4     
+ Partials       11       10       -1     
Impacted Files Coverage Δ
pkg/redis-json.go 94.94% <100.00%> (+3.27%) ⬆️

@slorello89 slorello89 requested a review from j8-redis July 5, 2023 13:38
@slorello89 slorello89 merged commit 7df1edd into master Jul 12, 2023
4 checks passed
@slorello89 slorello89 deleted the bugfix/json-get-scalars branch July 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisJSON path fails to display non-string data
2 participants