avoid deep recursions by introducing multiple RSQNodes under a single… #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swilly22 the search part looks good to me, I am less familiar with the rest of the changes... |
jeffreylovitz
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
The utilize_indices logic all looks sound to me, and @MeirShpilraien has signed off on the RediSearch components, so this seems good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the way we construct RediSearch queries for
INfilters,Consider:
MATCH (n) WHERE n.v IN [0,1,2,3,4,5,6,7,8,9] RETURN nThis used to be translated in to a nested OR filter:
n.v = 0 OR n.v = 1 OR n.v = 2 OR n.v = 3 OR ...and similarly a nested UNION RediSearch query, causing deep recursions as can be seen in the following image
This PR takes advantage of multi child UNION RediSearch query node(s) which reduces the depth of the query tree.