Lock on write proc #1573
Merged
Lock on write proc #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreylovitz
suggested changes
Feb 12, 2021
src/schema/schema.c
Outdated
| @@ -85,34 +85,47 @@ int Schema_AddIndex(Index **idx, Schema *s, const char *field, IndexType type) { | |||
| return INDEX_OK; | |||
| } | |||
|
|
|||
| int Schema_RemoveIndex(Schema *s, const char *field, IndexType type) { | |||
| static int _schema_RemoveExactMatchIndex(Schema *s, const char *field) { | |||
There was a problem hiding this comment.
Nit - _Schema_RemoveExactMatchIndex
src/schema/schema.c
Outdated
| } | ||
|
|
||
| return INDEX_OK; | ||
| } | ||
|
|
||
| static int _schema_RemoveFullTextIndex(Schema *s) { |
There was a problem hiding this comment.
Nit - _Schema_RemoveFullTextIndex
| ResultSet_IndexDeleted(result_set, res); | ||
| Schema *s = GraphContext_GetSchema(gc, label, SCHEMA_NODE); | ||
|
|
||
| if(s != NULL) { |
Comment on lines
+42
to
+43
| if(GraphContext_AddIndex(&idx, gc, label, field, IDX_FULLTEXT) == INDEX_OK) { | ||
| res = INDEX_OK; |
There was a problem hiding this comment.
res = GraphContext_AddIndex(&idx, gc, label, field, IDX_FULLTEXT);
if(res != INDEX_OK) break;
FWIW the older approach had the benefit of resolving the schema only once, but I don't mind this change if you think it's a better abstraction.
There was a problem hiding this comment.
not only abstraction, but this way will make sure the statistics are updated, we can't break here as there might be several fields being added out of which some might already exists. we want to construct only if the user presented a new field
swilly22
force-pushed
the
lock-on-write-proc
branch
from
eb55359
to
baeea0f
Compare
swilly22
added a commit
that referenced
this pull request
Feb 14, 2021
* write lock when invoking write procedure * replicate index modifications
swilly22
added a commit
that referenced
this pull request
Feb 16, 2021
* Avoid postponed array (#1569) * WIP * persist projected values * remove emit record * Lock on write proc (#1573) * write lock when invoking write procedure * replicate index modifications * Use file streaming endpoint to parse queries (#1572) * Use file streaming endpoint to parse queries * Revert change to default parse buffer size * Address PR comments Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* write lock when invoking write procedure * replicate index modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1570