fix shutdow issue #1882
Merged
fix shutdow issue #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1882 +/- ##
==========================================
+ Coverage 86.24% 86.34% +0.09%
==========================================
Files 247 247
Lines 21453 21459 +6
==========================================
+ Hits 18502 18528 +26
+ Misses 2951 2931 -20
Continue to review full report at Codecov.
|
swilly22
previously approved these changes
Aug 19, 2021
| @@ -77,3 +77,7 @@ void ThreadPools_SetMaxPendingWork | |||
| uint64_t val | |||
| ); | |||
|
|
|||
| void ThreadPools_Destroy | |||
There was a problem hiding this comment.
Add comments explaining what this function does
jeffreylovitz
pushed a commit
that referenced
this pull request
Aug 25, 2021
* fix shutdow issue * destroy thread pools before shutdown * Update pools.h Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit ea48059)
swilly22
pushed a commit
that referenced
this pull request
Aug 25, 2021
* slowlog shouldn't create graph (#1878) * slow log shouldn't create graph * address review * Update test_slowlog.py Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit b5b667f) * move to multi process tests (#1877) * move to multi process tests * skip tests in valgrind * convet stress test * comment * convert concurrent query test * address review * rename * increase stress test work Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 2c80051) * fix shutdow issue (#1882) * fix shutdow issue * destroy thread pools before shutdown * Update pools.h Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit ea48059) * implement quantifier (#1880) * implement quantifier * update doc * address review * allow NULL value in compact * fix comment * fix comment * address review * Update commands.md * fix disable test for coverage * exlude only test02_clean_shutdown from coverage * Update test_concurrent_query.py * Update test_pending_queries_limit.py * Update test_query_mem_limit.py Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 1976ed1) * fix #1879 fix readme example (#1884) (cherry picked from commit 7a1b834) * Graphblas restore cache (#1885) * Disable GraphBLAS cache retrieval * Modify GraphBLAS cache key Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit fc678ea) * Tuple iterator now updates properly when changing matrix to serialize (#1889) * Tuple iterator now updates properly when changing matrix to serialize * Update encode_graph_entities.c Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 51fe376) * validate set items (#1892) * validate set items * add test * fix leak * Update ast_validations.c * Update ast_validations.c * Update test_entity_update.py Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit e9e696e) * Synchronize matrices on creation in RDB load (#1888) * Synchronize matrices on creation in RDB load * Update decode_graph.c * Only sync graph-level adjacency matrix, update previous decoders * Update test_persistency.py * Flush all matrices on RDB load Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 3ecc74f) * Refresh GraphBLAS cache (#1894) (cherry picked from commit 46fabda) * bump version to 2.8.3 Co-authored-by: Avi Avni <avi.avni@gmail.com> Co-authored-by: Guy Korland <gkorland@gmail.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* fix shutdow issue * destroy thread pools before shutdown * Update pools.h Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.