Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate set items #1892

Merged
merged 6 commits into from Aug 25, 2021
Merged

validate set items #1892

merged 6 commits into from Aug 25, 2021

Conversation

AviAvni
Copy link
Collaborator

@AviAvni AviAvni commented Aug 24, 2021

fix for #1891

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1892 (2d075c6) into master (51fe376) will decrease coverage by 0.00%.
The diff coverage is 90.47%.

❗ Current head 2d075c6 differs from pull request most recent head 46bd8b1. Consider uploading reports for the commit 46bd8b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
- Coverage   86.42%   86.42%   -0.01%     
==========================================
  Files         247      247              
  Lines       21515    21533      +18     
==========================================
+ Hits        18594    18609      +15     
- Misses       2921     2924       +3     
Impacted Files Coverage Δ
src/ast/ast_validations.c 89.07% <90.47%> (-0.01%) ⬇️
src/util/thpool/thpool.c 82.38% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c82c1...46bd8b1. Read the comment docs.

jeffreylovitz
jeffreylovitz previously approved these changes Aug 24, 2021
Copy link
Contributor

@jeffreylovitz jeffreylovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good!

@swilly22 swilly22 merged commit e9e696e into master Aug 25, 2021
@swilly22 swilly22 deleted the validate-set-items branch August 25, 2021 05:34
jeffreylovitz pushed a commit that referenced this pull request Aug 25, 2021
* validate set items

* add test

* fix leak

* Update ast_validations.c

* Update ast_validations.c

* Update test_entity_update.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit e9e696e)
swilly22 pushed a commit that referenced this pull request Aug 25, 2021
* slowlog shouldn't create graph (#1878)

* slow log shouldn't create graph

* address review

* Update test_slowlog.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit b5b667f)

* move to multi process tests (#1877)

* move to multi process tests

* skip tests in valgrind

* convet stress test

* comment

* convert concurrent query test

* address review

* rename

* increase stress test work

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 2c80051)

* fix shutdow issue (#1882)

* fix shutdow issue

* destroy thread pools before shutdown

* Update pools.h

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit ea48059)

* implement quantifier (#1880)

* implement quantifier

* update doc

* address review

* allow NULL value in compact

* fix comment

* fix comment

* address review

* Update commands.md

* fix disable test for coverage

* exlude only test02_clean_shutdown from coverage

* Update test_concurrent_query.py

* Update test_pending_queries_limit.py

* Update test_query_mem_limit.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 1976ed1)

* fix #1879 fix readme example (#1884)

(cherry picked from commit 7a1b834)

* Graphblas restore cache (#1885)

* Disable GraphBLAS cache retrieval

* Modify GraphBLAS cache key

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit fc678ea)

* Tuple iterator now updates properly when changing matrix to serialize (#1889)

* Tuple iterator now updates properly when changing matrix to serialize

* Update encode_graph_entities.c

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 51fe376)

* validate set items (#1892)

* validate set items

* add test

* fix leak

* Update ast_validations.c

* Update ast_validations.c

* Update test_entity_update.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit e9e696e)

* Synchronize matrices on creation in RDB load (#1888)

* Synchronize matrices on creation in RDB load

* Update decode_graph.c

* Only sync graph-level adjacency matrix, update previous decoders

* Update test_persistency.py

* Flush all matrices on RDB load

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 3ecc74f)

* Refresh GraphBLAS cache (#1894)

(cherry picked from commit 46fabda)

* bump version to 2.8.3

Co-authored-by: Avi Avni <avi.avni@gmail.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
* validate set items

* add test

* fix leak

* Update ast_validations.c

* Update ast_validations.c

* Update test_entity_update.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants