Re-run persistency tests on AOF-enabled servers #1896
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1896 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 247 247
Lines 21648 21648
=======================================
Hits 20081 20081
Misses 1567 1567
Continue to review full report at Codecov.
|
| else | ||
| # mac | ||
| ifeq ($(VALGRIND),) | ||
| # no valgrind | ||
| @python3 -m RLTest --module ../../src/redisgraph.so $(TEST_ARGS) | ||
| # rerun persistency tests using AOF | ||
| @python3 -m RLTest --module ../../src/redisgraph.so --use-aof -t test_persistency $(TEST_ARGS) |
There was a problem hiding this comment.
@MeirShpilraien
Can --use-aof be specified by the actual test file? as an argument to RLTest.Env ?
There was a problem hiding this comment.
Env accepts a useAof argument, but two environments can't be live simultaneously, so we would need to duplicate the tests to run under both RDB and AOF.
There was a problem hiding this comment.
@jeffreylovitz @MeirShpilraien
how about we introduce 2 new classes both inheriting from testGraphPersistency?
class testGraphPersistency(FlowTestsBase):
def __init__(self, useAof):
self.env = Env(decodeResponses=True, useAof=useAof)
...
class testGraphPersistencyAOF(testGraphPersistency):
super(testGraphPersistency, True)
class testGraphPersistencyRDB(testGraphPersistency):
super(testGraphPersistency, False)
There was a problem hiding this comment.
We can as well define a shared function that both tests calls to after creating the env, but I remember @jeffreylovitz wanted to avoid this. This is why I suggested this way..
* Re-run persistency tests on AOF-enabled servers * clean-up Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com> (cherry picked from commit 53ddab0)
* Re-run persistency tests on AOF-enabled servers * clean-up Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com>
No description provided.