#RI-4380 BE Upload data in bulk base implementation #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @ApiPropertyOptional({ | ||
| type: 'string', | ||
| format: 'binary', | ||
| description: 'Import file (with list of commands to execute', |
There was a problem hiding this comment.
I guess you lost close round bracket.
| progress: null, | ||
| filter: null, | ||
| status: BulkActionStatus.Completed, | ||
| duration: Date.now(), |
There was a problem hiding this comment.
Maybe will be better to create another constant startBulkActionTime or something else, it will be more clear i guess. And in the end result.duration = Date.now() - startBulkActionTime. But it is up to you.
There was a problem hiding this comment.
sure. if this will be more easy to understand
AmirAllayarovSofteq
approved these changes
Apr 10, 2023
ArtemHoruzhenko
merged commit 621bc95
into
feature/RI-4290-upload_data_in_bulk
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.