Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#RI-5003 show scan more always when next cursor is non-zero #2675

Merged
merged 2 commits into from
Oct 16, 2023
Merged

#RI-5003 show scan more always when next cursor is non-zero #2675

merged 2 commits into from
Oct 16, 2023

Conversation

ArtemHoruzhenko
Copy link
Collaborator

No description provided.

@ArtemHoruzhenko ArtemHoruzhenko self-assigned this Oct 11, 2023
@zalenskiSofteq
Copy link
Collaborator

tests are failed

@ArtemHoruzhenko
Copy link
Collaborator Author

tests are failed

@zalenskiSofteq Fixed tests.
Also I had to skip old test for keys details in the footer since nextCursor is not passed into the ScanMore component and it is not shown there anymore.
I've added "todo" so please take a look later. Probably we must remove obsolete tests and code

@vlad-dargel vlad-dargel merged commit 5dc8507 into main Oct 16, 2023
11 checks passed
@vlad-dargel vlad-dargel deleted the fe/bugfix/RI-5003-fix-non-zero-scan-cursor branch October 16, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romansergeenkosofteq romansergeenkosofteq romansergeenkosofteq approved these changes

@zalenskiSofteq zalenskiSofteq Awaiting requested review from zalenskiSofteq

Assignees

@ArtemHoruzhenko ArtemHoruzhenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArtemHoruzhenko @zalenskiSofteq @romansergeenkosofteq @vlad-dargel